search

mohamicorp / stash-jenkins-postreceive-webhook

Webhook used to notify Jenkins when commits are made to Stash
Other
138 stars 100 forks source link

Restore PR event handling #125

Closed ashnazg closed 9 years ago

ashnazg commented 9 years ago

Restore the PR event handling method body. Pull Requests are seeing no handling whatsoever (new creation, new commits added) right now.

Looking back at @loa's comments on the original commenting-out commit, it sounds like their use case would be better served by the Jenkins jobs' branch settings being tighter. We need the notifications themselves as free as possible, and then it's up to the Jenkins jobs to know what to poll against (and thus choose to build or not).

loa commented 9 years ago

There are no need to take my PR into consideration on the future of this plugin.

My PR was WIP (work in progress) and merged prematurely when I was about leave the employee that used this. I would never leave comments in checked in code :(

mikesir87 commented 9 years ago

Yeah... and I'm sorry it got merged in. Still trying to figure out the best way to manage an open-source project. Definitely the first project I've had that was big enough to actually have others contribute too (woot!).

@ashnazg - I'll get this merged in if you remove the comment/text that @mihu was referring to.

loa commented 9 years ago

@mikesir87 I'm sorry for leaving the project in a mess :(

It was hard to continue with contributions (both cause of technical and motivational reasons) since I left the company that had Stash + Jenkins. Especially since I couldn't get all use-cases to play along without creating a big refactor.

Hope this project will continue to thrive, it's crazy that all these git hosting softwares are dependent on open source projects to create integration with Jenkins.

ashnazg commented 9 years ago

@mikesir87 -- comment removed, ready for merge.

mikesir87 commented 9 years ago

@ashnazg Excellent. Thanks!

@loa - No worries for leaving. And like, you, I've been considering doing a refactor of the codebase. The only thing I haven't figured out yet would be migrating current settings over. I don't want to force everyone to go and re-setup their repositories.