search

mohamicorp / stash-jenkins-postreceive-webhook

Webhook used to notify Jenkins when commits are made to Stash
Other
138 stars 100 forks source link

Unable to switch back from SSH/HTTP to Custom #183

Closed jlwt90 closed 6 years ago

jlwt90 commented 7 years ago

Hello, I encountered the following issue:

1) open this form screen shot 2017-03-03 at 17 51 05

2) change type to HTTP (or SSH) screen shot 2017-03-03 at 17 56 12

3) change back to Custom screen shot 2017-03-03 at 17 56 33

As you may notice, the field is still disabled. So I checked the JS (jenkins.js)

I think .removeProp("disabled") doesn't work here. It should be fine if we change it to .prop("disabled", false).

Does anyone find the same issue?

thrownullpointer commented 7 years ago

I have not seen this before. What browser are you using? What version of stash or bitbutcket?

jlwt90 commented 7 years ago

Hi @thrownullpointer ,

Thanks for your reply. I am using Atlassian Bitbucket v4.8.6.

Doesn't work for the browsers below. Firefox Developer Edition: 55.0b3 Safari: Version 10.0 (12602.1.50.0.10) Chrome: Version 58.0.3029.110 (64-bit)

Thanks!

SirJane commented 6 years ago

I have been experiencing this with Bitbucket v4.12, and Firefox 54.0.1 (and 2-3 earlier versions). There doesn't seem to be a workaround, except hit "cancel" and start over.

marvinthepa commented 6 years ago

I fixed this in #194, see https://github.com/Nerdwin15/stash-jenkins-postreceive-webhook/pull/194/files#diff-6127cafb8b70cf899b75a802223d3d14

alexBraidwood commented 6 years ago

Committed the patch submitted by @marvinthepa. I didn't come across any issues running it on my end, but please see if this patch fixes the issues you're coming across.

jlwt90 commented 6 years ago

@marvinthepa thanks! I think it's fixed already!