search

mohamicorp / stash-jenkins-postreceive-webhook

Webhook used to notify Jenkins when commits are made to Stash
Other
138 stars 100 forks source link

Enable SNI #194

Closed marvinthepa closed 6 years ago

marvinthepa commented 6 years ago

fixes #104 (although not by upgrading SNI, but by using the new API introduced in httpclient 4.3 instead of the deprecated ones).

This also includes minor fixes in the Javascript for the connection test, because it annoyed me while testing this 😄 .

I also took the freedom to disable host name checking when ticking "Skip SSL Certificate Validation" (also see #176), because it made sense to me. Please let me know if this should be an extra pull request and/or configurable on its own.

alexBraidwood commented 6 years ago

@marvinthepa , I'll be getting this in this weekend. There's a backlog of PRs and I'm working my way through them to minimize conflicts and issues.

marvinthepa commented 6 years ago

@alexBraidwood thanks. We have been running a patched version in production for some time and have not experienced any issues (although I don't really know how much people depend on it, so I can't say if we would have caught any issues if they exist).