Setup automated build on GitHub

mohamicorp / stash-jenkins-postreceive-webhook

Webhook used to notify Jenkins when commits are made to Stash

Other

138 stars 98 forks source link

Setup automated build on GitHub #200

Open ppodgorsek opened 7 years ago

ppodgorsek commented 7 years ago

Strangely enough, no automated build has been set up for this project. This would allow to perform a first check of all pull requests before a manual review is done. CodeShip could be a good option, as it allows 100 free builds per months, which should be more than enough for this project.

This depends on PR #199, as it contains the dependency version fix required for automated builds.

ppodgorsek commented 7 years ago

If using CodeShip:

Install the CodeShip service by going to the project's settings in GitHub > Integration & services > Add service

The following commands should be used to setup the project:

jdk_switcher home oraclejdk8
jdk_switcher use oraclejdk8
mvn clean

The following command should be used to run the tests: (will compile at the same time)
```
mvn -B test
```

A branch protection for master must also be defined:

Go to the project's settings in GitHub > Branches > Choose a branch > master
The following boxes must be checked:
- Protect this branch
- Require pull request reviews before merging
- Require status checks to pass before merging
- Require branches to be up to date before merging
- CodeShip required
- Include administrators

alexBraidwood commented 7 years ago

This is great idea and I'll definitely look into getting this set up. I might need to get a hold of the repository owner to put this together, though.

I did have another thought, however: What do you think about dogfooding this project with Bitbucket and Jenkins? I wouldn't mind reaching out to Atlassian for a freebie server license.

ppodgorsek commented 7 years ago

Having a Bitbucket + Jenkins setup would be great for integration tests.

Nevertheless, I don't think we should use that setup for continuous integration, as our build would be dependent on the code we are actually maintaining (circular loop). The latest major BitBucket release is a good example, as the plugin was not working with that version but we would have needed the plugin to approve any pull request to fix the issue.