Notify Jenkins upon merged Pull-Requests

mohamicorp / stash-jenkins-postreceive-webhook

Webhook used to notify Jenkins when commits are made to Stash

Other

138 stars 98 forks source link

Notify Jenkins upon merged Pull-Requests #4

Closed kuhnroyal closed 11 years ago

kuhnroyal commented 11 years ago

notify Jenkins upon merged Pull-Requests
use Stash NavBuilder API to create Repo-URL (only need to override Stash base URL in settings if custom URL is used)
extracted notification code in a separate class
added a main logo
requires Stash 2.3.0

Please review and comment!

mikesir87 commented 11 years ago

Wow! Nice addition! I've take a quick look at it and it seems great, but there's a few things I'm not too familiar with, so want to look into it a little more - mostly around the fact that I'm new to Mockito and Stash/Atlassian plugin development. So, I'll spend the next day or two to look at it, run it, and comment where necessary.

Thanks!

kuhnroyal commented 11 years ago

Sounds good!

mikesir87 commented 11 years ago

After looking at the code a little more, I feel it looks great to merge in.

Just one suggestion... looking at a pull request someone else just sent me (link below), can you add an example of what the override setting might look like? At first glance, I wasn't sure of the format that it should take, but looking at the code, it made sense. Don't want to cause confusion for others. After that, I'll send go ahead and merge it in.

Thanks!

https://github.com/jcostello84/stash-jenkins-postreceive-webhook/commit/a20980cea7013d2297e7c3d069b0a47adb94cbbb

kuhnroyal commented 11 years ago

done