search

mohamicorp / stash-jenkins-postreceive-webhook

Webhook used to notify Jenkins when commits are made to Stash
Other
138 stars 98 forks source link

Better error message when trigger build fails #51

Closed ritzmann closed 10 years ago

ritzmann commented 10 years ago

When you press the "Trigger Jenkins" button and something goes wrong, it displays "It didn't work!" Would it be possible to display a more helpful error message that would indicate what didn't work?

ws-kimmo-helsing commented 10 years ago

Looks like it shows this message in case the Jenkins in question doesn't have any jobs which would use the specified Stash repository URL. Agree, a more descriptive message would improve the usability a lot.

mikesir87 commented 10 years ago

Excellent idea. Shouldn't be too hard to come up with something for that. I'll get on it.

mikesir87 commented 10 years ago

I've got it working on my machine. Might you be willing to try out a test version of the plugin? If so, you can access the latest snapshot at the URL below.

To install, you will need to uninstall the current version, then install this one. All existing configuration will persistent and no changes should be required. If it looks good, I'll go ahead and ship it out!

http://nerdwin15.com/dist/stash-plugin/stash-webhook-jenkins-2.2.2-SNAPSHOT.jar

ritzmann commented 10 years ago

Sure, thanks for the quick work! I'll see if we can give it a spin on Monday.

ws-kimmo-helsing commented 10 years ago

Installed this on our Stash. Now there's a nice error message given in case there are no Jenkins jobs using the given repository URL. Good job :+1:

kuhnroyal commented 10 years ago

Good job!

mikesir87 commented 10 years ago

Great! I'll work on getting the release out on the Marketplace. Thanks for taking a look! :)

mikesir87 commented 10 years ago

Just an FYI... went ahead and decided to make it version 2.3. I realized that the version I used in the SNAPSHOT I sent to you all was 2.2.2, which was the current released version. Oops! Version controlling... such a pain sometime. :)

ws-kimmo-helsing commented 10 years ago

Noticed, but doesn't really matter as I uninstalled the old version and installed the new one on top of it. Might be it now wants to upgrade itself to the 2.3 version even though it is basically the same... But this is what you get when using Maven :)