search

mohamicorp / stash-jenkins-postreceive-webhook

Webhook used to notify Jenkins when commits are made to Stash
Other
138 stars 98 forks source link

Can SCM changes such as Approved, Merged be ignored when triggering Jenkins build #89

Open faiyat opened 9 years ago

faiyat commented 9 years ago

I have noticed not only new commit in the from branch of pull request can trigger new Jenkins build, the Approved or Merged event in the pull request can also trigger a new builds which indicate no SCM change. This can unnecessarily block the build machine resource for no real SCM change. Can the webhook code not send notification to Jenkins for these type of events? Right now it seems Jenkins side does not have option to ignore such events.

christiangalsterer commented 9 years ago

Actually I think it is good that these events also a trigger Jenkins. The problem is more that it is not configurable IMO. See also https://github.com/Nerdwin15/stash-jenkins-postreceive-webhook/issues/83 for a more detailed discussion.

mikesir87 commented 9 years ago

Hi there! Yeah... the plugin currently doesn't offer a lot in the area of configuration. This can certainly be a configuration option. I'm planning to introduce a lot more configuration (as well as a global config section) that will let you make these types of choices.

However, in this case, the merge would be a new commit on the branch to which the merge is going. So, it may be a little tough to separate out a "this was a commit from a pull request". I'll see what I can do though.