search

mohammadKarimi / SwiftLink

SwiftLink is a modern URL shortener with Asp.net Core 8
MIT License
105 stars 26 forks source link

Update a swiftlink #69

Closed mohammadKarimi closed 8 months ago

mohammadKarimi commented 8 months ago

Updates fields in the specified link.

parhamdarvishi commented 8 months ago

mohammad I want to add this option to system.

mohammadKarimi commented 8 months ago

It is yours now 😉

parhamdarvishi commented 8 months ago

its an honor.

I create a PR -> "UpdateLinkAPI"

so I have some question around this issue: witch fields must be in update: now I only added title.

another question is about the result of API: what is the best practice for API result? is it good to only return bool ?(I used this type) or we must create custom output DTO?

mohammadKarimi commented 8 months ago

its an honor.

I create a PR -> "UpdateLinkAPI"

so I have some question around this issue: witch fields must be in update: now I only added title.

another question is about the result of API: what is the best practice for API result? is it good to only return bool ?(I used this type) or we must create custom output DTO?

I sent you which fields must be updated, now you can see them on your PR.