mohammedDehairy / MDSlideNavigationViewController

34 stars 9 forks source link

Please clean up code #1

Open aaronbrethorst opened 11 years ago

aaronbrethorst commented 11 years ago

thanks!

mohammedDehairy commented 11 years ago

i fixed the issues

thanks ,i appreciate it

On Sat, Jun 22, 2013 at 7:30 PM, Aaron Brethorst notifications@github.comwrote:

-

There's a concerning warning on compilation

There are a number of methods that only call super

There's some no-op code (e.g. viewImage = nil;)

Method naming conventions should match platform expectations.

if(animated==YES) is redundant, should just be if (animated) or if (!animated)

thanks!

— Reply to this email directly or view it on GitHubhttps://github.com/mohammedDehairy/MDSlideNavigationViewController/issues/1 .