mohanadarafe / GuideMe

SOEN 390 | Winter 2020 | Mini Capstone
7 stars 5 forks source link

Indoor Directions | Adding H9 Map + Directions #168

Closed mohanadarafe closed 4 years ago

mohanadarafe commented 4 years ago

In this PR, I am adding H9 floor map, directions from & to it + small modifications to algorithms. #162

Test

  1. Open the app
  2. Press on the search bar
  3. Query a classroom
  4. Press on Get Directions in the bottom menu
  5. Enter a from classroom
  6. Enter a to classroom
  7. Press on the arrow back
  8. Press on the Hall Building inside the map
  9. Press on Get Inside in the bottom menu
  10. Navigate to the floors you have queried directions for
mohanadarafe commented 4 years ago

Overall

You are very good and you make this feature looks very easy. Though, I think your solution is hard to extend. How hard would it be for someone who doesn't know your code to do it? If the answer is easy, You're the man. 🥇 From what I'm seeing, it's tedious.

Steps to add a floor map: 1) Convert SVG Map to React Native SVG function using playground 2) Create node graph & layout coordinates of classrooms

This is simple, but, if we had an AI detecting coordinates for us (such as checkpoints & what-not), this would be easy to extend. For now, we stick to writing out the graph ourself.