Closed bloulidi closed 4 years ago
Hi,
I tested your branch and came across 2 things:
Page is empty when calendar is not connected
When connecting to my calendar, you can notice the first email has a location being an address. It allows me to go to the double search & from there get an error. Add error handling for valid locations to be classes only. I think @AlainJobs wrote an algorithm for that already.
Hi,
I tested your branch and came across 2 things:
Page is empty when calendar is not connected
When connecting to my calendar, you can notice the first email has a location being an address. It allows me to go to the double search & from there get an error. Add error handling for valid locations to be classes only. I think @AlainJobs wrote an algorithm for that already.
Did you do that @AlainJobs ?
I tested your app now & I noticed 2 major bugs:
1- Turn off the switch for Google Calendar but the label stills shows Current status is ON 2- My calendar does not show up
I tested your app now & I noticed 2 major bugs:
1- Turn off the switch for Google Calendar but the label stills shows Current status is ON 2- My calendar does not show up
Both are now fixed !! Thank you for the retro.
Hi,
I tested your branch and came across 2 things:
Page is empty when calendar is not connected
When connecting to my calendar, you can notice the first email has a location being an address. It allows me to go to the double search & from there get an error. Add error handling for valid locations to be classes only. I think @AlainJobs wrote an algorithm for that already.
Fixed both issues!!
Just tested again. The switch works well but I still cannot see my schedule.
Just tested again. The switch works well but I still cannot see my schedule.
What do you see in your course schedule screen ?
Just tested again. The switch works well but I still cannot see my schedule.
What do you see in your course schedule screen ?
Nothing π€£
I log in to my Google Account, it has a schedule, but on the Course Schedule page none of the events load up.
Just tested again. The switch works well but I still cannot see my schedule.
What do you see in your course schedule screen ?
Nothing π€£
I log in to my Google Account, it has a schedule, but on the Course Schedule page none of the events load up.
This is weird because i can see mine, make sure your events are after the current date.
Just tested again. The switch works well but I still cannot see my schedule.
What do you see in your course schedule screen ?
Nothing π€£ I log in to my Google Account, it has a schedule, but on the Course Schedule page none of the events load up.
This is weird because i can see mine, make sure your events are after the current date.
Its fixed !!
In this pull request, you will find the following features:
Log in/Log out of your google calendar in settings and select a calendar.
View the events of a calendar in course schedule.
Go to my next class arrow in course schedule if the user wrote a location for that event in his calendar.
When the user log-in to his google account, account will stay active until the user decides to log-out (Persistent even after closing the app).
Todo next π
Issues π¨π¨π¨
When testing the app, you might encounter an error when trying to sign in with google. This is going to be fixed by alain who studied redux specifically to fix it. This happens because we sort of leave the app and get back to it when we sign in (related to async storge). For now, if you see the error, just restart the app. it happens half the time you log in. For more details on this please ask @AlainJobs.
This is not to be merged to master right away, as i said alain fixed the async storage issue with redux. We want to see if there are no bugs with this version first.
To test the app π―
Create a new calendar in your google calendar account.
Create events and add a description & a location. (The location will be used as a placeholder in doubleSearch)
Open settings and sync in with google.
You may find a page where it says do you trust the app, just click on advanced options and continue
Select a calendar in the list bellow
Go check your events in course schedule
Events with locations will have an arrow next to them to give directions to the class.
SPECIAL THANKS to @AlainJobs @csbduzi for helping me alot during this featureπ. I learned a lot from you guys ππ