mohanadarafe / GuideMe

SOEN 390 | Winter 2020 | Mini Capstone
7 stars 5 forks source link

Feature/google calendar #224

Closed bloulidi closed 4 years ago

bloulidi commented 4 years ago

In this pull request, you will find the following features:

  1. Log in/Log out of your google calendar in settings and select a calendar.

  2. View the events of a calendar in course schedule.

  3. Go to my next class arrow in course schedule if the user wrote a location for that event in his calendar.

  4. When the user log-in to his google account, account will stay active until the user decides to log-out (Persistent even after closing the app).

Todo next πŸ“‘

Issues 🚨🚨🚨

To test the app 🎯

  1. Create a new calendar in your google calendar account.

  2. Create events and add a description & a location. (The location will be used as a placeholder in doubleSearch)

  3. Open settings and sync in with google.

  4. You may find a page where it says do you trust the app, just click on advanced options and continue 93617554_854779998267202_7793870194757074944_n

  5. Select a calendar in the list bellow

  6. Go check your events in course schedule

  7. Events with locations will have an arrow next to them to give directions to the class.

SPECIAL THANKS to @AlainJobs @csbduzi for helping me alot during this featureπŸ˜‡. I learned a lot from you guys πŸ™ŒπŸ™Œ

mohanadarafe commented 4 years ago

Hi,

I tested your branch and came across 2 things:

Page is empty when calendar is not connected IMG_8197

When connecting to my calendar, you can notice the first email has a location being an address. It allows me to go to the double search & from there get an error. Add error handling for valid locations to be classes only. I think @AlainJobs wrote an algorithm for that already. IMG_8198

bloulidi commented 4 years ago

Hi,

I tested your branch and came across 2 things:

Page is empty when calendar is not connected IMG_8197

When connecting to my calendar, you can notice the first email has a location being an address. It allows me to go to the double search & from there get an error. Add error handling for valid locations to be classes only. I think @AlainJobs wrote an algorithm for that already. IMG_8198

Did you do that @AlainJobs ?

mohanadarafe commented 4 years ago

I tested your app now & I noticed 2 major bugs:

1- Turn off the switch for Google Calendar but the label stills shows Current status is ON 2- My calendar does not show up

bloulidi commented 4 years ago

I tested your app now & I noticed 2 major bugs:

1- Turn off the switch for Google Calendar but the label stills shows Current status is ON 2- My calendar does not show up

Both are now fixed !! Thank you for the retro.

bloulidi commented 4 years ago

Hi,

I tested your branch and came across 2 things:

Page is empty when calendar is not connected IMG_8197

When connecting to my calendar, you can notice the first email has a location being an address. It allows me to go to the double search & from there get an error. Add error handling for valid locations to be classes only. I think @AlainJobs wrote an algorithm for that already. IMG_8198

Fixed both issues!!

mohanadarafe commented 4 years ago

Just tested again. The switch works well but I still cannot see my schedule.

bloulidi commented 4 years ago

Just tested again. The switch works well but I still cannot see my schedule.

What do you see in your course schedule screen ?

mohanadarafe commented 4 years ago

Just tested again. The switch works well but I still cannot see my schedule.

What do you see in your course schedule screen ?

Nothing 🀣

I log in to my Google Account, it has a schedule, but on the Course Schedule page none of the events load up.

bloulidi commented 4 years ago

Just tested again. The switch works well but I still cannot see my schedule.

What do you see in your course schedule screen ?

Nothing 🀣

I log in to my Google Account, it has a schedule, but on the Course Schedule page none of the events load up.

This is weird because i can see mine, make sure your events are after the current date.

bloulidi commented 4 years ago

Just tested again. The switch works well but I still cannot see my schedule.

What do you see in your course schedule screen ?

Nothing 🀣 I log in to my Google Account, it has a schedule, but on the Course Schedule page none of the events load up.

This is weird because i can see mine, make sure your events are after the current date.

Its fixed !!