search

mohanadarafe / GuideMe

SOEN 390 | Winter 2020 | Mini Capstone
7 stars 5 forks source link

Reduce Code Duplication + Refactoring #242

Closed AlainJobs closed 4 years ago

AlainJobs commented 4 years ago

Overview

  1. We resolved logic duplication found by SonarQube.
  2. Constant files (not src) were removed from the code duplication coverage for the reason that they are files with no logic (data structures) and would not have existed in our app if we had a database.
  3. LocationMarker and Map.js were slightly edited.
    • The layout of the two buttons breaks when we change screen size.
    • LocationMarker was fetching the wrong currentLocation.

Try it out

You can branch out and test if nothing was broken. Extra pairs of eyes are useful!

Related to #200 and Fixes #239