mohanasundaramn / ms-flutter-packages

Custom flutter package collection
MIT License
8 stars 23 forks source link

onDone and onSkip callbacks aren't working in OnBoard widget, but are made mandatory. #10

Closed karthikreddi closed 3 years ago

karthikreddi commented 3 years ago

Describe the bug

  1. onDone and onSkip callbacks aren't working in OnBoard widget, but are made mandatory.
  2. The following assertion was thrown during layout: A RenderFlex overflowed by 204 pixels on the bottom.

The relevant error-causing widget was OnBoard lib/…/intro_screens/intro_slider_page_8.dart:12

Expected behavior

  1. Whatever code is inserted in onDone and onSkip callbacks should be executed.
  2. Check for overflow on small devices like motorola.

Remove them as there is skipButton and nextButton where the same can be achieved.

mohanasundaramn commented 3 years ago

Exception:

Screenshot 2021-07-13 at 3 18 00 PM
mohanasundaramn commented 3 years ago

@karthikreddi You can see the changes in v1.0.1

mohanasundaramn commented 3 years ago

Overflow issue for the smaller devices is fixed in V1.0.2

zionnite commented 2 years ago

am using V2.0.0 and issue still persist, please how do i resolve this??