search

mohandev2 / openhpi_old

Other
0 stars 0 forks source link

uid_map creation fails if directory is missing #1914

Closed mohandev2 closed 6 years ago

mohandev2 commented 8 years ago

/var/lib/openhpi is installed by default on linux systems. That directory could be removed by user by accident/mistake. If uid_map creation fails, we need to check if that directory exists. If that directory does not exist and is needed then openhpid could exit with an error asking the user to reinstall the packages or create the directory before proceeding.

Reported by: mohandev2

Original Ticket: openhpi/bugs/1914

mohandev2 commented 8 years ago

Please review the patch.

Original comment by: mohandev2

mohandev2 commented 8 years ago

Original comment by: erpraveenk

mohandev2 commented 8 years ago

Fixed in checkin #7674 & #7675

Original comment by: erpraveenk

mohandev2 commented 6 years ago

the patche causes the following errors when the user calls "make check" in the build process. In my opinion it's an regression.

FAIL: uid_utils_000

(process:12112): t-CRITICAL **: uid_utils.c:483: uid map file directory '/var/lib/openhpi' does not exist. Either re-install the package or create the directory maunally.

(process:12112): t-WARNING **: uid_utils.c:174: UID map file directory does not exist. FAIL uid_utils_000 (exit status: 1)

FAIL: uid_utils_001

(process:12119): t-CRITICAL **: uid_utils.c:483: uid map file directory '/var/lib/openhpi' does not exist. Either re-install the package or create the directory maunally.

(process:12119): t-WARNING **: uid_utils.c:174: UID map file directory does not exist. FAIL uid_utils_001 (exit status: 1)

FAIL: uid_utils_002

(process:12126): t-CRITICAL **: uid_utils.c:483: uid map file directory '/var/lib/openhpi' does not exist. Either re-install the package or create the directory maunally.

(process:12126): t-WARNING **: uid_utils.c:174: UID map file directory does not exist. FAIL uid_utils_002 (exit status: 1)

FAIL: uid_utils_003

(process:12133): t-CRITICAL **: uid_utils.c:483: uid map file directory '/var/lib/openhpi' does not exist. Either re-install the package or create the directory maunally.

(process:12133): t-WARNING **: uid_utils.c:174: UID map file directory does not exist. FAIL uid_utils_003 (exit status: 1) ...

Original comment by: ngothan