Context manager should not suppress exceptions

mohankishore / python_dynamodb_lock

Python package that emulates the dynamodb-lock-client java library from awslabs

Other

49 stars 21 forks source link

Context manager should not suppress exceptions #426

Open nazarewk opened 5 years ago

nazarewk commented 5 years ago

Description

https://github.com/mohankishore/python_dynamodb_lock/blob/1a2725a83534cd544f5faec75681c0ae8c835143/python_dynamodb_lock/python_dynamodb_lock.py#L880-L886

I don't think context manager should suppress exceptions, makes for very annoying debugging experience and error handling.

benjackwhite commented 5 years ago

Looks like https://github.com/mohankishore/python_dynamodb_lock/pull/285 actually is a nice solution to this exact issue. I get the feeling this project isn't being maintained... @mohankishore any thoughts on how you might want support with regards to maintain this package?

danrue commented 4 years ago

@nazarewk @benjackwhite I'm looking to use python_dynamodb_lock but it appears unmaintained. Are you using it in production or have you found something better?

yelizariev commented 4 years ago

There is a fork with the applied fix

You can install it with following command

    pip install git+https://github.com/whatnick/python_dynamodb_lock.git

See also #819

whatnick commented 4 years ago

This fork now has a pypi package : https://pypi.org/project/python-dynamodb-lock-whatnick/ . More coming soon. I will fix up the CI pipeline and tag the source repo properly. During the Github downtime period yesterday my own CI pipeline failed to install from Github and I pushed from my local clone to PyPI to resuscitate my pipeline. I will do this properly soon. I am actively using this in my production deployment for Nairobi Rain Radar.