mohanson / gameboy

Full featured Cross-platform GameBoy emulator by Rust. Forever boys!.
MIT License
1.36k stars 79 forks source link

render in terminal via blockish #22

Closed yazgoo closed 4 years ago

yazgoo commented 4 years ago

video demos:

zelda: https://www.youtube.com/watch?v=ou_4WSuYRHk pokemon yellow: https://youtu.be/XcrkZnIS1lM

mohanson commented 4 years ago

I found that you have removed the WIP tag, but it still seems to be doing some work. If the PR is ready, please @ me, I will test and check it.

Thank you for your work.

yazgoo commented 4 years ago

@mohanson yep, the PR is ready :)

mohanson commented 4 years ago

@yazgoo

  1. Please fix their build warnings:
    
    warning: use of deprecated item 'std::error::Error::description': use the Display impl or to_string()
    --> src\main.rs:128:26
    |
    128 |         None => {let _ = execute!(stdout(),terminal::EnterAlternateScreen);},
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(deprecated)]` on by default
    = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
warning: use of deprecated item 'std::error::Error::description': use the Display impl or to_string() --> src\main.rs:161:25 161 let _ = execute!(stdout(),cursor::MoveTo(0,0)); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
warning: use of deprecated item 'std::error::Error::description': use the Display impl or to_string() --> src\main.rs:227:26 227 None => {let _ = execute!(stdout(),terminal::LeaveAlternateScreen);}, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

warning: 3 warnings emitted



2. This UI does not work well on windows, you need to fix it, or simply disable the use of terminal mode on windows, both ok.

![image](https://user-images.githubusercontent.com/12387889/85964954-df1f9c80-b9ed-11ea-801c-fd0ea88e575e.png)
yazgoo commented 4 years ago

Thanks !