search

mohaps / lrucache11

A header only C++11 LRU Cache template class that allows you to define key, value and optionally the Map type. uses a double linked list and a std::unordered_map style container to provide fast insert, delete and update No dependencies other than the C++ standard library. This is a C++11 remake of my earlier LRUCache project (https://github.com/mohaps/lrucache) The goal was to create a fast LRUCache header only library and to avoid any dependencies like boost.
https://github.com/mohaps/lrucache11
294 stars 63 forks source link

enable compilation on gcc 5.4 ubuntu #3

Closed ekg closed 8 years ago

mohaps commented 8 years ago

@ekg - better still, make a Makefile. I was going to make one. But I think a Makefile for the sample is a better idea

ekg commented 8 years ago

Sure can do.

On Wed, Aug 31, 2016, 19:03 Saurav Mohapatra notifications@github.com wrote:

@ekg https://github.com/ekg - better still, make a Makefile. I was going to make one. But I think a Makefile for the sample is a better idea

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mohaps/lrucache11/pull/3#issuecomment-243849195, or mute the thread https://github.com/notifications/unsubscribe-auth/AAI4EYeXvvvewDDRVand996A09Iakt7bks5qlcIFgaJpZM4JxyqJ .

breznak commented 8 years ago

Thanks @ekg for the PR, not only needed for gcc 5.4, but for gcc 4.8, clang 3.7 etc too! Fixes #6 for me :+1:

@mohaps could you please merge this urgently? (and leave a Makefile to a separate PR? Personally, I don't see a reason for a Makefile, as the project's aim seems to be "being a single simple header file", so it is intended to be included into existing projects only as a header and using theirs (c)make files)

mohaps commented 8 years ago

Closing this as I updated the readme and the pull request for std::list implementation added the include