search

moharamfatema / sys_linear_eqns_python

Solving systems of linear equations using numerical methods - python
0 stars 0 forks source link

code structure could use some improvements #1

Closed moharamfatema closed 2 years ago

moharamfatema commented 2 years ago

@NourhanWaleed

This is a GUI application however, the functions interact directly with the user through the console. you should restructure your functions so that :

  1. All the data they need is passed as parameters to the function.
  2. You should return the result of your function either as a return variable ( for example: a dictionary) or an output file (preferably JSON), instead of the output being logged to the console.
  3. These functions should not call the system to terminate the entire program, what if we want to handle this error in a certain way?? Try raising exceptions.