search

mohit5189 / SurvayApp

0 stars 0 forks source link

Localization #8

Open edgarss opened 4 years ago

edgarss commented 4 years ago

why aren't you using Localizable.strings file if you want to have localized strings?

mohit5189 commented 4 years ago
Screenshot 2020-07-24 at 4 48 35 PM Screenshot 2020-07-24 at 4 48 29 PM

If you look above screenshots, I am reading from Localizable.strings only. Here I created a new class just to avoid rewriting logic for string reading

edgarss commented 4 years ago

Sorry for not making myself more clear. You're right it makes sense for a small app like this. but you would run into issues in an app with hundreds of strings. I would recommend to use something like R.swift that creates an enum for localized strings and assets automatically.

mohit5189 commented 4 years ago

Agree with you, made changes to R.swift