search

mohitanand001 / underscore_cpp

underscore_cpp
MIT License
7 stars 30 forks source link

Set union added #22

Closed rvmzes closed 6 years ago

gotham13 commented 6 years ago

@blowdee Please create a new branch for every pull request you make. Yo will have to reset your master branch to this repos branch. Create a new branch from that master and then add your changes.

rvmzes commented 6 years ago

@Gotham13121997 I messed up a bit, but just merged afterwards. Is it ok?

gotham13 commented 6 years ago

Yeah. By creating new branches you can work on several issues side by side. Now you cant work on another issue unless this one is merged . So take care of it from the next time.

rvmzes commented 6 years ago

Missed that. Should be fine now.

gotham13 commented 6 years ago

Please use const_iterator in place of iterator where possible. Do it for intersection as well. Thanks for contributing

gotham13 commented 6 years ago

Tested and merged to master

gotham13 commented 6 years ago

Thanks @blowdee . Please create a new branch if you want to contribute to new issues