search

mohitanand001 / underscore_cpp

underscore_cpp
MIT License
7 stars 30 forks source link

While loop bracket not closed. #45

Closed gotham13 closed 6 years ago

gotham13 commented 6 years ago

https://github.com/farziengineer/underscore_cpp/blob/1cbccc7abe4bed208e971b330fc2d06f787d8651/underscore.cpp#L281

gotham13 commented 6 years ago

Please take care of indentation and bracketing as well. Curly Brackets should be in separate lines for all.

mohitanand001 commented 6 years ago

Before taking up this issue please ask this to be assigned. We do not want more than one person to work on the same issue.

shubhamcr commented 6 years ago

I think the curly brace for the while loop at line 288 is also not closed. Can I take this one ?

gotham13 commented 6 years ago

sure

shubhamcr commented 6 years ago

Please assign it to me

mohitanand001 commented 6 years ago

Sure @shubhamcr go ahead.

shubhamcr commented 6 years ago

I have raised the pull request. Kindly review: https://github.com/farziengineer/underscore_cpp/pull/46

shubhamcr commented 6 years ago

I want to add one more comment that please use some styling/indentation check tool for your repository. The indentation gets messed up when the changes are made in the local repo and pushed to origin.

gotham13 commented 6 years ago

@shubhamcr thats a nice suggestion we will look into it. Thanks.

gotham13 commented 6 years ago

closed via #46