warning and clang-tidy cleanup

mohitanand001 / underscore_cpp

underscore_cpp

MIT License

7 stars 30 forks source link

Closed gubatron closed 6 years ago

gubatron commented 6 years ago

clang warning 'no previous prototype for function' on testing's display, incr, mulp, is_odd, multiply
clang-tidy for loop range refactors
precision loss in count_by function could've ocurred if count was a long number
tidy, removed extra space in size() declaration

gubatron commented 6 years ago

thank you so much for the trust.

I'm looking now at the underscore js project to mimic their tests.

If you agree, we should create a src and a tests folder so we can have formal testing.

I'd include Catch2 as the testing library via git submodule, catch2 is a header only testing library that I've used in other projects.

Then we could integrate travis to have the tests run whenever somebody sends a Pull Request.

gubatron commented 6 years ago

mohitanand001 commented 6 years ago

Hi, I have left you a message on LinkedIn, can you please have a look.

mohitanand001 commented 6 years ago

Thanks for the suggestion @gubatron . We can start working on this.

gubatron commented 6 years ago

Hi there, was on the road this weekend. I'm going to look at all the tickets and see if this should be done first.

mohitanand001 commented 6 years ago

Sure