search

mohitanand001 / underscore_cpp

underscore_cpp
MIT License
7 stars 30 forks source link

Consistent bracketing style #78

Closed mohitanand001 closed 5 years ago

mohitanand001 commented 5 years ago

Some places have opening brackets starting on same line, while some of them have brackets on a new line.

mohitanand001 commented 5 years ago

Better to go with brackets on new line, looks cleaner.

gubatron commented 5 years ago

yes, more C++ style. (it's hard for me to not do this unconsciously, been coding in java daily for 14 years), I think I'm going to add a hook before commits that applies proper clang-format to it and forbid's me from comitting if I have a mistake.

gubatron commented 5 years ago

Closed with this https://github.com/farziengineer/underscore_cpp/pull/82