mohitanand001 / underscore_cpp

underscore_cpp
MIT License
7 stars 30 forks source link

fixed wrong position bug in max #8

Closed gotham13 closed 6 years ago

gotham13 commented 6 years ago

Fixes #1

The container was being passed by value. This was creating a new instance of the container in a different memory location. Thus the difference was a weird value. An & solved the issue

gotham13 commented 6 years ago

Will commit changes in #6 after this is merged to master to avoid merge conflicts

mohitanand001 commented 6 years ago

Thanks a lot. 🙂