search

mohitjaisal / CodingBooks

As you begin your path on becoming a coding specialist it is always pleasant to find good sources of information. Many computer languages might be tricky to learn at the beginning so you need reliable references to double-check your mistakes and learn how to not make them again.
https://codingbooks.netlify.app/
MIT License
15 stars 34 forks source link

Create about page #37

Closed mohitjaisal closed 3 years ago

mohitjaisal commented 3 years ago

Create an about page and add some details you can use readme.md for details

Mmollle commented 3 years ago

I can do this, you can assign it to me.

mohitjaisal commented 3 years ago

@Mmollle Go ahead 👍🏻

davidchengl74 commented 3 years ago

Hello, I can create the about page for you. I am doing this for school assignment. The request needs to be merged for me to receive credit for my school assignment. Can you kindly let me know if this can work, and the issue can be assigned to me? I can work with other contributor's submission as well. Thank you very much

mohitjaisal commented 3 years ago

Yeah, @davidchengl74 you can work on this issue or upgrade it further with @Mmollle 👍

davidchengl74 commented 3 years ago

Alright and thank you please allow me to look into it. And will create and send the PR soon.

davidchengl74 commented 3 years ago

Hi, I've created the About page, with file About.html. However, I cannot submit any pull request maybe it is not linked to any file? The page is highly reused based on AddABook page, and styles.css is added with a new class 'AboutTheProject' where style is same as "LinkDrive" class.

Is there anyway I can merge the pull request for the About.html and styles.css?

I am sure further artistic styling refinements are needed. Output image:

Screenshot from 2021-10-21 21-36-35

mohitjaisal commented 3 years ago

Good to go @davidchengl74 but make sure it won't have any errors and it is responsive

davidchengl74 commented 3 years ago

The GIF is responsive And all navi functions are working. I still need to add the About.html file but I can push the any new file to repository Any way you can set up the pull request, for index.html about html, and styles.css Need the pull request link show merged for me to get credit for my school assignment Thank you very much

davidchengl74 commented 3 years ago

So, total 3 files were updated.

index.html about.html styles.css

I have submitted 3 PRs for those. Basically Index will have an additional Navi to About About.html contains all the about information. styles.css contains the styles used in about page. All need to be merged in order to work Please kindly check, as the PR show closed.

Raeskaa commented 3 years ago

Hey, I'd like to work on your About us page Id' like to give you an example of how I'm gonna make the UI image It will be responsive and ill be adding animations in it.

mohitjaisal commented 3 years ago

@Raeskaa you can go ahead but make sure about the theme color of the project don't create the background of any other color it should match with our project theme color

davidchengl74 commented 3 years ago

Hi @mohitjaisal I think the About.html file needs to be merged so the index can reference to it. And the HTML file is needed for opening the about page. The file is written mirroring the AddABook page so all functions, theme, color are the same.
Further edits can be done at the file. It is intended as a skeleton page linked with navigation bar from Index and AddABook pages.

Raeskaa commented 3 years ago

@Raeskaa you can go ahead but make sure about the theme color of the project don't create the background of any other color it should match with our project theme color

Yeah sure! Thankyou!