search

mohitsoni / marathon-client

Java API client for Mesosphere's Marathon.
Apache License 2.0
50 stars 89 forks source link

Implementation some APIs of the Marathon and error decoder #4

Closed blurblah closed 9 years ago

blurblah commented 9 years ago

I think this library is very useful for marathon users (including me). So I'd like to go on with contribution to this. I have implemented some APIs below.

  1. POST /v2/groups
  2. DELETE /v2/groups/{groupId}
  3. GET /v2/groups/{groupId}
  4. GET /v2/deployments
  5. DELETE /v2/deployments/{deploymentId}

and added an error decoder for http error responses. MarathonException throws when

  1. request app information which not existed
  2. create existing app (duplicate or conflict)
  3. delete not-existed app
  4. request group information which not existed
  5. create existing group
  6. delete not-existed group

About my some commits, I've modified some codes for docker container and return value.

Please let me know if you have problems with this commits.

mohitsoni commented 9 years ago

Changes looks good to me, except one minor change that I mentioned above. Also, it would be great if you can please squash your commits, before I merge them.

blurblah commented 9 years ago

I've removed commented code and squashed all my commits.

mohitsoni commented 9 years ago

Thanks for pull request!