search

mohitsood5934 / Group-Chat-Private-Chat-Application-using-MEAN-And-Socket.io

Creating Group Chat and Private Chat Application using Socket.IO
11 stars 13 forks source link

Code formatting #8

Open damien-white opened 4 years ago

damien-white commented 4 years ago

This is mostly my opinion, but I really think that a formatter such as prettier in conjunction with a linter such as ESLint (@typescript-eslint with eslint-plugin or TSLint if you prefer) would really go a long way in making your code more consistent and readable.

Please, don't get me wrong -- the current state of the codebase is not bad or terrible by any means. I really like this project for a variety of reasons.

Using the code-formatting/linting tools I mentioned above also actually tend to help with maintainability.

Just a friendly suggestion, really. Great work! 👍

mohitsood5934 commented 4 years ago

Thanks Peter,surely I will use prettier and will update the codebase. I was not active on github from long time due to some other projects.Thanks for the suggestion.