mohkale / flymake-collection

Collection of checkers for flymake
MIT License
68 stars 13 forks source link

Set the working dir and shadow file flag for mypy #9

Closed dmitrig closed 1 year ago

dmitrig commented 2 years ago

Mypy requires some configuration in most cases, which it looks for in its working directory by default. You can check that flymake-collection-mypy won't work with projects like urllib3 at the moment. This updates flymake-collection-mypy to set default-directory to a parent dir containing a config file, if it exists. It also adds the mypy --shadow-file flag to make sure types are defined in the right module and caching works when processing temp files. Also includes minor tweaks to make flags customizable and parse out the diagnostic id.

Some things to consider:

jgarte commented 2 years ago

Hi, what's the status on this? This PR would be so awesome to get merged in for me. I'll be using it.

mohkale commented 1 year ago

LGTM. Thanks @dmitrig.