search

mohsen1 / json-formatter

Angular directive for collapsible JSON in HTML
http://azimi.me/json-formatter/demo/demo.html
Other
372 stars 85 forks source link

Wrap .key colon strings with a span tag #38

Closed ultrabluewolf closed 8 years ago

ultrabluewolf commented 8 years ago

Differentiate between text of key and appended colon for styling flexibility.

mohsen1 commented 8 years ago

If there is no CSS that uses those new elements why we need it? Can you share a before/after screenshot set to show the improvement?

ultrabluewolf commented 8 years ago

Currently, there is no way to differentiate between the key and the colon added by the template. Let's say you pull in this library, but you are overriding css. In this case you would have to style that entire node if you wanted to adjust styling for the keys which might not be what the user wants.

mohsen1 commented 8 years ago

Ok, makes sense. I'll merge it.