search

mohsen1 / json-formatter

Angular directive for collapsible JSON in HTML
http://azimi.me/json-formatter/demo/demo.html
Other
372 stars 85 forks source link

Capability to select items using checkboxes #56

Closed 31piy closed 5 years ago

31piy commented 8 years ago

This pull request contains the following changes:

  1. Adds a new option (elementsSelectable) to JSONFormatterConfig to enable element selection mode using checkboxes.
  2. Users can optionally provide a model with the json-formatter directive. This will update the model automatically with the expression of selected items.
  3. A new service ($jsonFormatter) which enables users to listen to the events when an item is selected/deselected.
  4. Update docs and specs to support this new option.
mohsen1 commented 8 years ago

Thank you for your pull request. It's a nice implementation and I like it. But I have to keep the scope of this directive small and avoid feature creep.

You can publish your fork and keep maintaining it but I rather not to merge this and keep this directive the way it is.

31piy commented 8 years ago

@mohsen1 I've created a separate repo for myself. Thank you for the core idea. :smiley: