mohsenasm / swarm-dashboard

A Simple Monitoring Dashboard for Docker Swarm Cluster
MIT License
162 stars 26 forks source link

PORT default value on Docker #20

Closed anton-johansson closed 8 months ago

anton-johansson commented 6 years ago

The PORT environment variable have a default value, see:

https://github.com/charypar/swarm-dashboard/blob/master/server/index.js#L9

const port = process.env.PORT || 8080;

However, when running on Docker, it uses the PORT environment variable when setting up the HEALTHCHECK, and that one has no default value. This was very confusing for me and it took me a while to realize why the container just shut down. :)

I think we should do one of the following: