search

moiexpositoalonsolab / grenepipe

A flexible, scalable, and reproducible pipeline to automate variant calling from raw sequence reads, with lots of bells and whistles.
http://grene-net.org
GNU General Public License v3.0
94 stars 21 forks source link

snpEff download directory only works with a trailing slash #12

Closed bensprung closed 2 years ago

bensprung commented 3 years ago

It appears that the snpeff download-dir parameter in config.yamlmust have a trailing slash to work properly, e.g. "/home/ben/my_download_dir/" works but with "/home/ben/my_download_dir" the downloads just go to my home folder. Not sure if that is the intended behavior (maybe just a warning about this in the comments would suffice?).

lczech commented 2 years ago

Weird. Okay, will investigate once I get to work on #13 ;-)

bensprung commented 2 years ago

Sounds good! I'll try to investigate as well.

On Thu, Dec 23, 2021 at 9:32 AM Lucas Czech @.***> wrote:

Weird. Okay, will investigate once I get to work on #13 https://github.com/moiexpositoalonsolab/grenepipe/issues/13 ;-)

— Reply to this email directly, view it on GitHub https://github.com/moiexpositoalonsolab/grenepipe/issues/12#issuecomment-1000343631, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACEMPU3QEUMZOQ6GCQIXVB3USMXHZANCNFSM5F3YKXIA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

lczech commented 2 years ago

Fixed, finally ;-)