search

moifort / homebridge-create-fan

Connect your create ceiling fan into homekit
Apache License 2.0
6 stars 3 forks source link

Change Brightness #9

Closed marsuboss closed 12 months ago

marsuboss commented 12 months ago

Hello,

When I upgraded from version 0.0.57 to version 0.0.66, I encountered the following issues:

Where changing the brightness from 0 to 52 while the device is on works correctly. However, when I attempt to change the brightness from 52 to 27, the change is successful, but the device turns off unexpectedly. Please refer to the log below for further details:

image

I think that's where it comes from, right?

https://github.com/moifort/homebridge-create-fan/blob/0f6d2ffb4028c0426f6d0789c0f37a2ee01b5aa4/src/platformAccessory.ts#L120

FYI: Same problem with fan speed.

moifort commented 12 months ago

My bad,

I just add this new feature to have a toggle switch. I will fix that !

Sorry !

marsuboss commented 12 months ago

No worries. Take your time 👍

moifort commented 12 months ago

I make (ugly) fix to avoid impacting the normal case. I test and it's work for me. Can you test it (v0.0.76). Tell me if it's work for you ?

marsuboss commented 12 months ago

I had to clear the cache, and this time it works fine, just as it should. Thank you for your assistance and expertise!