search

moigagoo / norm

A Nim ORM for SQLite and Postgres
https://norm.nim.town
MIT License
378 stars 34 forks source link

Removed unnecessary variable assignment #162

Closed PhilippMDoerner closed 1 year ago

PhilippMDoerner commented 1 year ago

This is a minor beautification thing. I should've caught that one with the last 2 PRs about this, but apparently I still missed this one. Doesn't change any logic, basically just allows people to get rid of an unnecessary warning.

moigagoo commented 1 year ago

Doesn't change any logic, basically just allows people to get rid of an unnecessary warning.

Meanwhile:

All checks have failed

😁

PhilippMDoerner commented 1 year ago

God, flipping... how?! Insert dramatic darth vader "Nooo" shout in the distance

PhilippMDoerner commented 1 year ago

I just ran the tests locally, they all pass.with this change. Looking at the checks, the error messages are all the same and appear unrelated to code:

Err:5 http://archive.ubuntu.com/ubuntu impish Release 404 Not Found [IP: 91.189.91.39 80] Err:6 http://archive.ubuntu.com/ubuntu impish-updates Release 404 Not Found [IP: 91.189.91.39 80] Err:7 http://archive.ubuntu.com/ubuntu impish-backports Release 404 Not Found [IP: 91.189.91.39 80] Err:8 http://security.ubuntu.com/ubuntu impish-security Release 404 Not Found [IP: 185.125.190.36 80] Reading package lists... E: The repository 'http://archive.ubuntu.com/ubuntu impish Release' no longer has a Release file. E: The repository 'http://archive.ubuntu.com/ubuntu impish-updates Release' no longer has a Release file. E: The repository 'http://archive.ubuntu.com/ubuntu impish-backports Release' no longer has a Release file. E: The repository 'http://security.ubuntu.com/ubuntu impish-security Release' no longer has a Release file.

Not sure what's going on there, could the pipelines in general be broken due to something Ubuntu did?

moigagoo commented 1 year ago

Not sure what's going on there, could the pipelines in general be broken due to something Ubuntu did?

Ubuntu Impish support ended several days ago: https://en.wikipedia.org/wiki/Ubuntu_version_history#Table_of_versions

The official Nim images were based off of this Ubuntu version.

Trying to build an image based on Focal, which is a LTS release.

PhilippMDoerner commented 1 year ago

@moigagoo They are compiling, huray!