moinulmoin / chadnext

ChadNext - Quick Starter Template for your Next project includes Next.js 14 App router, Shadcn UI, LuciaAuth, Prisma, Server Actions, Stripe, Internationalization and more.
https://chadnext.moinulmoin.com
MIT License
840 stars 75 forks source link

🐛 FIX(github/email): fix github oauth scope & callback handler #201

Closed ahmedrowaihi closed 3 months ago

ahmedrowaihi commented 4 months ago

I believe this was missed

vercel[bot] commented 4 months ago

Someone is attempting to deploy a commit to a Personal Account owned by @moinulmoin on Vercel.

@moinulmoin first needs to authorize it.

ahmedrowaihi commented 4 months ago

hey @moinulmoin I guarantee a blind merge for this :')

moinulmoin commented 3 months ago

If you hadn't mixed it with irrelevant changes, I would have been happy to merge. Thanks for the PR though.

ahmedrowaihi commented 3 months ago

@moinulmoin what was irrelevant ? both are related to email : D

simply we can rename this PR if you think the name was more clear

moinulmoin commented 3 months ago

@moinulmoin what was irrelevant ? both are related to email : D

  • github sign in doesn't return email unless you define the scope
  • email was not imported so I added it

simply we can rename this PR if you think the name was more clear

okay, please rename this pr and add the following changes, then we are good to merge.

ahmedrowaihi commented 3 months ago

@moinulmoin is this better ? I also rebased the branch so it doesn't conflict with latest merges and keeps the commits clean

moinulmoin commented 3 months ago

Awesome bro, good job. Thank you so much for the PR

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chadnext ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 0:22am
ahmedrowaihi commented 3 months ago

Awesome bro, good job. Thank you so much for the PR

All thanks to you!