search

moinwiki / moin-1.9

MoinMoin Wiki (1.9, also: 1.5a ... 1.8), stable, for production wikis
https://moinmo.in/
Other
140 stars 53 forks source link

SubProcess code calling os.setsid too early #44

Closed ThomasWaldmann closed 5 years ago

ThomasWaldmann commented 5 years ago

https://github.com/moinwiki/moin-1.9/blob/master/MoinMoin/util/SubProcess.py#L31

 preexec_fn=None if subprocess.mswindows else os.setsid(),

Guess the parentheses should not be there, we need to give the function, not call it and give the result.

ThomasWaldmann commented 5 years ago

https://github.com/moinwiki/moin-1.9/commit/00b8212b3e647370d588d9dfd790af63b97fc782

changeset that introduced this bug while fixing another one (in 1.9.10).