moiph / ub3r-b0t

A Discord/IRC Bot
MIT License
94 stars 23 forks source link

.w returns either 0% or 100% for chance of precipitation #36

Closed enamelizer closed 1 year ago

enamelizer commented 1 year ago

Example output: Light rain, 42F (6C) (279K) / feels like 41F (5C) (278K) | High: 42F (6C) (279K) | Low: 41F (5C) (278K) | Humidity: 85% | Wind: WSW @ 3mph (5km/h) | 0% chance of precipitation (Seattle, WA 98126, USA)

My guess is that the value from the API call is not getting converted to a percentage correctly.

This commit is possibly related: https://github.com/moiph/OpenWeatherMap.API/commit/cfe66ceed73d9484d7749d298139018c05b5582a

moiph commented 1 year ago

Woops, I patched that part and didn't fix up the usage for the bot. Thanks for catching and reporting. Fixed now :)

ahpook commented 1 year ago

This is fixed upstream : https://github.com/thomasgalliker/OpenWeatherMap.API/blob/develop/OpenWeatherMap/Models/WeatherForecastItem.cs#L34

@moiph if you update your fork this will get fixed for free 👍