search

moiristo / deep_cloneable

This gem gives every ActiveRecord::Base object the possibility to do a deep clone that includes user specified associations.
MIT License
786 stars 88 forks source link

Add has_one through support #97

Closed vladislav-yashin closed 6 years ago

moiristo commented 6 years ago

Thanks for your PR! I like it, except for the checks on enumerable methods (respond_to?(:select), respond_to?(:map)). Since there is also some duplicate code in dup_has_many_association, I'll try to adapt it a little by extracting shared code to methods, making it a little more DRY and simpler to read. Will look into it this week.

moiristo commented 6 years ago

Superseded by #98.