moisescastellano / javadecompiler-tcplugin

JavaDecompiler Total Commander plugin
GNU General Public License v3.0
4 stars 1 forks source link

%COMMANDER_PATH% does not expand in JVM_DLL #3

Closed Konfekt closed 2 years ago

Konfekt commented 2 years ago

The path to the JVM_DLL cannot be found if it is given by the set environment variable%COMMANDER_PATH% instead of its value in the section [JVM] in the file tc_javaplugin.ini.

Konfekt commented 2 years ago

This is in contrast to the use of this environment variable in the other settings of tc_javaplugin.ini, where it works fine

moisescastellano commented 2 years ago

Hi Konfekt: Thanks for reporting. %COMMANDER_PATH% is set by TC to its own path, so do you mean you are trying to set the JVM dll path relative to the TC folder? You are right, just now %COMMANDER_PATH% is being used to solve relative paths just for these 2 variables:

Konfekt commented 2 years ago

Dear @moisescastellano, exactly. It was just the idea of creating a portable version of Totalcommander including your plug-in and the JRE

Konfekt commented 2 years ago

I am closing this issue as it could be argued that it is the duty of the user to set %COMMANDER_PATH% which happens during install. In this case Total Commander was a portable application and %COMMANDER_PATH% unset. Still, inside Total Commander this environment variable is set and perhaps this plugin could read it; thus this issue is rather a feature request, albeit rather specialized.

moisescastellano commented 2 years ago

Fine. Thanks for the suggestion.