search

moisseev / rspamd-spamness

Thunderbird add-on for visualizing rspamd spam scores.
BSD 3-Clause "New" or "Revised" License
53 stars 13 forks source link

Spam score missing in column picker on Thunderbird 115 #35

Open lo92fr opened 9 months ago

lo92fr commented 9 months ago

Hello,

First, thanks a lot for this very good extension. I have an issue on my current setup : Thunderbird 115 / Windows. When I want to enable the "Spam score" column, I can't find it in the column picker. All the other functions is working great. Let me know if I can check something on my side.

Thunderbird rspamd

Best regars, Laurent.

moisseev commented 9 months ago

Unfortunately the score column feature is not supported on Thunderbird Supernova for now.

Blocked by bug 1817682

image

lo92fr commented 9 months ago

Hello,

Thanks for your quick answer. I haven't notice the warning message in the options :(.

Laurent.

realizelol commented 7 months ago

If I understand them correctly there are some interesting news @ https://bugzilla.mozilla.org/show_bug.cgi?id=1817682 As this bug was closed 2 days ago.

It just looks like that the sorting of this column is actually still buggy, but I think that is not the main focus: https://bugzilla.mozilla.org/show_bug.cgi?id=1877390

Hope to hear sth. new soon.

realizelol commented 4 months ago

Even bug https://bugzilla.mozilla.org/show_bug.cgi?id=1817682 has been closed 3 month ago. There are a lot more detailed threads which are also for the new released TB 115.10.

I'm no developer but this patch looks promising: https://hg.mozilla.org/releases/comm-esr115/rev/6051d34851df

moisseev commented 4 months ago

Is it stable? I'll wait at least until it is announced and API is documented.

adlerweb commented 3 months ago

As some Add-ins started adopting the new API, I made a crude attempt at copying their code. Spaminess-Column can be displayed and score is shown. Icons are still broken, also settings ui won't open, so consider the code only as a test. Test XPI can be found at https://github.com/adlerweb/rspamd-spamness/releases/tag/supernova-1 - use at your own risk…

moisseev commented 3 months ago

@adlerweb,

Icons are still broken

https://github.com/adlerweb/rspamd-spamness/commit/ed2dece266421b27a4702da73718095be68ebb08#diff-acd17dc167bd3f7e293448db0145cd6d504fa5247e526f59815b6278ac3debeeR51

As far as I can see, your iconCallback returns an icon URL, but it should return an id of the icon, which should be defined in the iconCellDefinitions.

https://github.com/mozilla/releases-comm-central/blob/a0082c2ba398172eafed1cc03e0c4fda5d4bcaa4/mail/base/content/modules/ThreadPaneColumns.mjs#L404-L479

realizelol commented 3 months ago

@adlerweb is it possible that moisseev adapt your code or to create a pull request where the maintainer is allowed to change the code?

Also in the german translation I wouldn't call the score Punkte something like Wertung or Spamwert is more clarified. Punkte sounds like dots and not a value. How do you think about that? I personally would recommend Spamwert. The same meaning also appears in different spelling Punkte, Spam-Wahrscheinlichkeit, SPAM-Punkte, 'Spam Punkte', 'SPAM-Punkte [Rspamd]' maybe that should also point to one spelling.

Thank you very much for your work that looks very promising to have the score column working again soon.

moisseev commented 3 months ago

Regarding the PR suggested by @realizelol , I am currently working on implementing columns properly, so there's no need to duplicate efforts.