search

moj-analytical-services / Rdbtools

Accessing Athena on the Analytical Platform
Other
4 stars 0 forks source link

Allow dbDisconnect to be used without library(noctua) or noctua:: #16

Closed mratford closed 1 year ago

mratford commented 1 year ago

The README has examples where dbDisconnect is called without adding the noctua library, which causes an error. This change allows users to call dbDisconnect from Rdbtools without worrying about noctua.

If you'd prefer to just edit the README to import noctua then that would be a good alternative.

pjrh-moj commented 1 year ago

looks good to me.

the alternative would be to add a new method in db_commands.R, which would let you do any moj specific cleanup at the same time (like cleaning out the temporary database - there are so many temp databases on the AP(!)). But this is clearer if it's just a straigh re-export.