moj-analytical-services / Rdbtools

Accessing Athena on the Analytical Platform
Other
4 stars 0 forks source link

`connect_athena` requires a value for `staging_dir` in `v0.5.0` #30

Closed andreassoteriadesmoj closed 3 months ago

andreassoteriadesmoj commented 3 months ago

Up to and including version v0.4.0, staging_dir = NULL was the default. From version v0.5.0, a non-empty value is required for this argument, otherwise access to the data sets is denied. See https://github.com/ministryofjustice/data-platform-support/issues/699

Having to specify the bucket in the staging directory argument for each and every dataset feels like overkill. Was this change intentional?

pjrh-moj commented 3 months ago

This isn't the intended behaviour, and isn't how it works for me. It looks like there may be a bug here, but it is more complicated than just the way Rdbtools handles the staging dir...

I am unable to replicate this

andreassoteriadesmoj commented 3 months ago

Version 0.5.2 seems to have resolved this issue.

(Some context: https://mojdt.slack.com/archives/C1PUCG719/p1718895990626449?thread_ts=1718876600.993429&cid=C1PUCG719)