Escape the full stop in the user id so it doesn't match everything.

moj-analytical-services / Rdbtools

Accessing Athena on the Analytical Platform

Other

4 stars 0 forks source link

Escape the full stop in the user id so it doesn't match everything. #4

Closed mratford closed 2 years ago

pjrh-moj commented 2 years ago

Oh dear - good spot. Was this just replacing every character with an underscore before? Can't believe I didn't spot that!

mratford commented 2 years ago

Yes it was - sorry, that was my mistake. I think I accepted that it worked - the very latest version of the platform introduces .s in the user name which it doesn't like in the db name, but is quite happy with mojap_temp_de_________________ and I obviously didn't check the actual string until now. Oops.

pjrh-moj commented 2 years ago

OK - I'm going to accept and merge this for now, but clearly the unit tests aren't working. I found it hard to work out how to do unit testing for this (e.g. when you're connecting to an external service). Will have another think.