search

moj-analytical-services / Rdbtools

Accessing Athena on the Analytical Platform
Other
4 stars 0 forks source link

Convenience function fix #6

Closed pjrh-moj closed 2 years ago

pjrh-moj commented 2 years ago

The convenience functions (well, at least create_temp_table) because it seems now you can only read tables within the same connection. Since create_temp_table makes its own connection and then closes it, then I think that table becomes inaccessible. This PR adds the ability to provide a connection object so people just need to update their code with a consistent connection object across the functions.

Also adds some extra documentation, mainly to cross-reference all the functions to noctua.

mratford commented 2 years ago

That looks good and is working for me.