moj-analytical-services / airflow-matrix-scraper

scraper for matrixbooking api
0 stars 2 forks source link

API query issues #53

Open williamorrie opened 2 months ago

williamorrie commented 2 months ago

Filtering API booking queries by Status (i.e. 'TENTITIVE' or 'CONFIRMED') only returns a subset of bookings compared to when no Status filter applied.

See original problem write up for further info and previous steps.

williamorrie commented 2 months ago

only admins can raise an SR with matrix booking, I did try to use the API credentials but theyre not admin.

williamorrie commented 2 months ago

Update

  1. Raising matrix SR for API status problems - Laurence to speak with new system owner
  2. Restricted Bookings - tested {"include": "restrictions"} param, only pulls in some hidden columns. Suggested API email apicalls@matrixbooking.com could be added to the restricted user group
  3. Curious about access to matrix data, want to be sure that there is only database access on the bucket and not, some how additions folder access from AP.
  4. Submitted PR to make Sue SRO - https://github.com/moj-analytical-services/data-engineering-database-access/pull/3732
williamorrie commented 1 month ago

Update - weekly catch-up

  1. Turns out there was previously an Matrix issue on the missing data raised by Chris Banbury, the respnse is here. Still doesn't change the fact that no current staff can raise an issue, suggested that api account be made an admin, then anyone could use that account to raise an issue, Laurence thought that might be security risk.
  2. Nothing heard back about adding apicalls to restricted group, but its up to them as they want the extra data
  3. I have removed folder access from several users and now only Andrew & Laurence have read-only folder access to the matrix bucket - https://controlpanel.services.analytical-platform.service.justice.gov.uk/datasources/338/
  4. done
hollyfurniss-moj commented 2 weeks ago

@PriyaBasker23 to check priority