search

moj-analytical-services / etl_manager

A python package to create a database on the platform using our moj data warehousing framework
21 stars 8 forks source link

Incorrect setter #141

Closed calumabarnett closed 2 years ago

calumabarnett commented 2 years ago

I think the following line should set self._glue_version: https://github.com/moj-analytical-services/etl_manager/blob/49c524c7b724c104e716aad78e160be107cbce8c/etl_manager/etl.py#L218

AnthonyCody commented 2 years ago

Above is in branch 49c524c7b7 (release v7.0.1, used for Glue v1 compatibility))

If it's wrong in that branch, is it also wrong in master branch? https://github.com/moj-analytical-services/etl_manager/blob/7795c2f15667e51710f5eb1e7f12be2c3237fa94/etl_manager/etl.py#L262