Closed isichei closed 6 years ago
Merging #38 into dev will increase coverage by
0.08%
. The diff coverage is91.96%
.
@@ Coverage Diff @@
## dev #38 +/- ##
==========================================
+ Coverage 64.58% 64.67% +0.08%
==========================================
Files 4 4
Lines 737 736 -1
==========================================
Hits 476 476
+ Misses 261 260 -1
Impacted Files | Coverage Δ | |
---|---|---|
etl_manager/etl.py | 53.36% <100%> (ø) |
:arrow_up: |
etl_manager/utils.py | 72.41% <100%> (ø) |
:arrow_up: |
etl_manager/meta.py | 55.9% <89.28%> (-0.62%) |
:arrow_down: |
tests/test_tests.py | 92.21% <94.33%> (-0.78%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a91d8df...2f71040. Read the comment docs.
This PR Closes issue #35, #36 and #37 Further changes to note:
Further changes to note
db_suffix has been dropped completely. To set a suffix do it manually e.g.
db.name = db.name + db_suffix
db = DatabaseMeta(folderpath)
is now replaced withdb = read_database_folder(folderpath)
.table = TableMeta(filepath)
is now replaced with table = read_table_json(filepath)`.DatabaseMeta()
andTableMeta()
constructors are now more standard with input parameters to define an object. e.g.table = TableMeta(name = 'table_name')
keys in a table json definition have been updated to align with database keys. Specifically
table_name
has been replaced withname
andtable_desc
has been changed withdescription
.