search

moj-analytical-services / etl_manager

A python package to create a database on the platform using our moj data warehousing framework
21 stars 9 forks source link

Added another check to the glue job parameters #48

Closed isichei closed 6 years ago

isichei commented 6 years ago

Glue Job Class will throw an error if the parameters have a dash in the name. Also added a unit test for Glue job parameters and removed duplicate tests on job params.

codecov-io commented 6 years ago

Codecov Report

Merging #48 into master will increase coverage by 0.72%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   74.06%   74.78%   +0.72%     
==========================================
  Files           4        4              
  Lines         798      805       +7     
==========================================
+ Hits          591      602      +11     
+ Misses        207      203       -4
Impacted Files Coverage Δ
etl_manager/etl.py 58.87% <100%> (+0.85%) :arrow_up:
tests/test_tests.py 95.51% <100%> (+1.47%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d0a9a6...05d45bd. Read the comment docs.

isichei commented 6 years ago

closes #46