moj-analytical-services / etl_manager

A python package to create a database on the platform using our moj data warehousing framework
21 stars 9 forks source link

Handle missing status's ["JobRun"]["ErrorMessage"] #51

Closed xoen closed 6 years ago

xoen commented 6 years ago

Unfortunately this key is not always there. I was expecting this key to be there as blank string when there were no errors but that's not the case.

This breaks wait_for_completion() :(

This should fix it.

codecov-io commented 6 years ago

Codecov Report

Merging #51 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   73.78%   73.78%           
=======================================
  Files           4        4           
  Lines         824      824           
=======================================
  Hits          608      608           
  Misses        216      216
Impacted Files Coverage Δ
etl_manager/etl.py 56.65% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update efbb6e0...4c95930. Read the comment docs.