search

moj-analytical-services / etl_manager

A python package to create a database on the platform using our moj data warehousing framework
21 stars 9 forks source link

change to job_run_state #53

Closed isichei closed 6 years ago

isichei commented 6 years ago

Tiny change to make the function return boto3 string unchanged i.e. uppercase rather than lowercase.

codecov-io commented 6 years ago

Codecov Report

Merging #53 into master will increase coverage by 0.08%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   73.78%   73.87%   +0.08%     
==========================================
  Files           4        4              
  Lines         824      823       -1     
==========================================
  Hits          608      608              
+ Misses        216      215       -1
Impacted Files Coverage Δ
etl_manager/etl.py 56.89% <0%> (+0.24%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6c0a81c...37064a0. Read the comment docs.

xoen commented 6 years ago

Happy with this.

Just bear 🐻 in mind this will break any code that uses this. I don't think it's a massive problem at this stage, so go ahead 💥